8318854: [macos14] Running any AWT app prints Secure coding warning

[amosshi]

Backport of JDK-8318854

Testing in Local: Passed on MacOS 14.4.1 (23E224)

• Before this Change, the message is shown
  • WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES.

SwingSet2 % pwd
SAPDevelop/github.com/dev-8318854-17/build/macosx-aarch64-server-slowdebug/images/jdk/demo/jfc/SwingSet2

SwingSet2 % ~/SAPDevelop/tools/java-17/Contents/Home/bin/java -version
openjdk version "17.0.10" 2024-01-16 LTS
OpenJDK Runtime Environment SapMachine (build 17.0.10+7-LTS)
OpenJDK 64-Bit Server VM SapMachine (build 17.0.10+7-LTS, mixed mode, sharing)

SwingSet2 % ~/SAPDevelop/tools/java-17/Contents/Home/bin/java -jar SwingSet2.jar 
2024-04-23 14:12:06.888 java[58220:367135] WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES.

• After this change, the message is gone

SwingSet2 % pwd
SAPDevelop/github.com/dev-8318854-17/build/macosx-aarch64-server-slowdebug/images/jdk/demo/jfc/SwingSet2

SwingSet2 % ~/SAPDevelop/github.com/dev-8318854-17/build/macosx-aarch64-server-slowdebug/images/jdk/bin/java -version
openjdk version "17.0.12-internal" 2024-07-16
OpenJDK Runtime Environment (slowdebug build 17.0.12-internal+0-adhoc.I048686.dev-8318854-17)
OpenJDK 64-Bit Server VM (slowdebug build 17.0.12-internal+0-adhoc.I048686.dev-8318854-17, mixed mode, sharing)

SwingSet2 % ~/SAPDevelop/github.com/dev-8318854-17/build/macosx-aarch64-server-slowdebug/images/jdk/bin/java -jar SwingSet2.jar 
2024-04-23 14:15:07.444 java[58929:372270] name is : .SFNS-Regular
2024-04-23 14:15:07.444 java[58929:372270] family is : .AppleSystemUIFont
2024-04-23 14:15:07.444 java[58929:372270] name is : .SFNS-Bold
2024-04-23 14:15:07.444 java[58929:372270] family is : .AppleSystemUIFont
2024-04-23 14:15:07.629 java[58929:372270] nsFont-name is : .AppleSystemUIFont
2024-04-23 14:15:07.629 java[58929:372270] nsFont-family is : .AppleSystemUIFont

Testing on Servers

• Pipeline: All checks have passed
• Testing Machine: SAP nightlies passed on 2024-04-17,19,20

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8318854 needs maintainer approval

Issue

• JDK-8318854: [macos14] Running any AWT app prints Secure coding warning (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2392/head:pull/2392
$ git checkout pull/2392

Update a local copy of the PR:
$ git checkout pull/2392
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2392

View PR using the GUI difftool:
$ git pr show -t 2392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2392.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318854: [macos14] Running any AWT app prints Secure coding warning

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• f70558d: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• 9912666: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• aa9c12b: 8315609: Open source few more swing text/html tests
• 2d27c94: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• c3438a5: 8305874: Open source AWT Key, Text Event related tests
• 94caa64: 8187759: Background not refreshed when painting over a transparent JFrame
• fbd0088: 8306634: Open source AWT Event related tests
• 7d19575: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• 80273fa: 8316242: Opensource SwingGraphics manual test
• 3f1c854: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode
• ... and 32 more: https://git.openjdk.org/jdk17u-dev/compare/c758755ccabb533f751fca65331b6e83732c2a8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (02d9040e)

[openjdk]

@amosshi
8318854: The approval request has been created successfully.

[amosshi]

/approval request "Backporting for parity with 17.0.12-oracle. Clean backport. SAP nightlies passed on 2024-04-17,19,20. Verified on local Laptop of MacOS 14.4.1”

[openjdk]

@amosshi
8318854: The approval request has been updated successfully.

[GoeLin]

Thanks for the testing!

[amosshi]

/integrate

[openjdk]

Going to push as commit 3324133.
Since your change was applied there have been 43 commits pushed to the master branch:

• 10b427d: 8329570: G1: Excessive is_obj_dead_cond calls in verification
• f70558d: 8283349: Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
• 9912666: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• aa9c12b: 8315609: Open source few more swing text/html tests
• 2d27c94: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
• c3438a5: 8305874: Open source AWT Key, Text Event related tests
• 94caa64: 8187759: Background not refreshed when painting over a transparent JFrame
• fbd0088: 8306634: Open source AWT Event related tests
• 7d19575: 8315741: Open source few swing JFormattedTextField and JPopupMenu tests
• 80273fa: 8316242: Opensource SwingGraphics manual test
• ... and 33 more: https://git.openjdk.org/jdk17u-dev/compare/c758755ccabb533f751fca65331b6e83732c2a8f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@amosshi Pushed as commit 3324133.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.