Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal #2411

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Apr 12, 2024

Backport of JDK-8327136

Testing

  • Local: Test passed on MacOS 14.4.1
    • NotifReconnectDeadlockTest.java: Test results: passed: 1
  • Pipeline:
  • Testing Machine:

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8327136 needs maintainer approval

Issue

  • JDK-8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2411/head:pull/2411
$ git checkout pull/2411

Update a local copy of the PR:
$ git checkout pull/2411
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2411/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2411

View PR using the GUI difftool:
$ git pr show -t 2411

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2411.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8f0fb27decec28f32e4d88341237189ba4a340fb 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

mlbridge bot commented Apr 12, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Apr 16, 2024

This ticket depends on #2399

  • Will redo it after pr-2399 will be merged

@amosshi amosshi closed this Apr 16, 2024
@amosshi amosshi deleted the backport-8327136 branch April 16, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant