-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer #2412
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
@luchenlin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 73 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you verify that the change fixes the issue (before/after test)?
Other than that: LGTM.
|
/integrate |
Going to push as commit d4512fe.
Your commit was automatically rebased without conflicts. |
@luchenlin Pushed as commit d4512fe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR contains a backport of
openjdk/jdk@6ce0ebb
Patch is not clean, for the doc/testing.html and doc/testing.md were only some code style changes in previous commits.
for this test/jdk/ProblemList.txt, it updated problemlist in
openjdk/jdk@8d2ad2b
, but this time I just do remove action, and it does not conflict with the previous commit.
for this class test/jdk/sun/security/pkcs11/PKCS11Test.java was changed in
openjdk/jdk@c2e77e2
, I ignored these commits, and the test has passed in my local.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2412/head:pull/2412
$ git checkout pull/2412
Update a local copy of the PR:
$ git checkout pull/2412
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2412/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2412
View PR using the GUI difftool:
$ git pr show -t 2412
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2412.diff
Webrev
Link to Webrev Comment