8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines

[neethu-prasad]

Notes

Backport of JDK-8317360

Verification

• jdk_jfr, Tier1 & Tier 2 tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317360 needs maintainer approval

Issue

• JDK-8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2601/head:pull/2601
$ git checkout pull/2601

Update a local copy of the PR:
$ git checkout pull/2601
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2601

View PR using the GUI difftool:
$ git pr show -t 2601

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2601.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back neethu-prasad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@neethu-prasad This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317360: Missing null checks in JfrCheckpointManager and JfrStringPool initialization routines

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 251b8e1: 8334333: MissingResourceCauseTestRun.java fails if run by root
• 4397fe8: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
• 789cb95: 8316306: Open source and convert manual Swing test
• 953a03d: 8321025: Enable Neoverse N1 optimizations for Neoverse V2
• 02ec672: 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests
• 0392d4e: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
• f9cc9e9: 8334332: TestIOException.java fails if run by root
• aa47dc7: 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out
• 9a45e2d: 8272777: Clean up remaining AccessController warnings in test library
• 01cb648: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712
• ... and 26 more: https://git.openjdk.org/jdk17u-dev/compare/9056b3bf10711e3a1a8cd91c4b33724f4e4aa9c0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @neethu-prasad This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (c6128eab)

[neethu-prasad]

/approval request Backport to fix missing null checks in JfrCheckpointManager and JfrStringPool initialization routines; applies cleanly; All tests passed; Risk is low as the code change is minimal i.e; adding null check.

[openjdk]

@neethu-prasad
8317360: The approval request has been created successfully.

[neethu-prasad]

Thanks for review & approval.

/integrate

[openjdk]

@neethu-prasad
Your change (at version c6128ea) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 70b623f.
Since your change was applied there have been 36 commits pushed to the master branch:

• 251b8e1: 8334333: MissingResourceCauseTestRun.java fails if run by root
• 4397fe8: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
• 789cb95: 8316306: Open source and convert manual Swing test
• 953a03d: 8321025: Enable Neoverse N1 optimizations for Neoverse V2
• 02ec672: 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests
• 0392d4e: 8318605: Enable parallelism in vmTestbase/nsk/stress/stack tests
• f9cc9e9: 8334332: TestIOException.java fails if run by root
• aa47dc7: 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out
• 9a45e2d: 8272777: Clean up remaining AccessController warnings in test library
• 01cb648: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712
• ... and 26 more: https://git.openjdk.org/jdk17u-dev/compare/9056b3bf10711e3a1a8cd91c4b33724f4e4aa9c0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @neethu-prasad Pushed as commit 70b623f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.