8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512)

[asgibbons]

JDK-8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512)

Backporting 8a8d9288980513db459f7d6b36554b65844951ca from original JBS.

Backport was not clean due to renaming of a file. Made changes in the old file consistent with the new file.

Tested release, fastdebug with tier1 and tier2.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8330611 needs maintainer approval

Issue

• JDK-8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512) (Bug - P3 - Approved)

Reviewers

• Sandhya Viswanathan (@sviswa7 - no project role)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2634/head:pull/2634
$ git checkout pull/2634

Update a local copy of the PR:
$ git checkout pull/2634
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2634/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2634

View PR using the GUI difftool:
$ git pr show -t 2634

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2634.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgibbons! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asgibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512)

Reviewed-by: sviswanathan, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 379a14b: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
• 313a7e0: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
• 4e702a4: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
• a4a0a82: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null'
• 3bdbf49: 8298809: Clean up vm/compiler/InterfaceCalls JMH
• 1070100: 8170817: G1: Returning MinTLABSize from unsafe_max_tlab_alloc causes TLAB flapping
• acff32c: 8328896: Fontmetrics for large Fonts has zero width
• 445aba4: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
• 5b43be2: 8317372: Refactor some NumberFormat tests to use JUnit
• 719f9ce: 8323584: AArch64: Unnecessary ResourceMark in NativeCall::set_destination_mt_safe
• ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/879e8031949d6cd6ce82027296dd2d4325faa2bb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[asgibbons]

/label hotspot
/label hotspot-compiler

[openjdk]

@asgibbons
The label hotspot is not a valid label.
These labels are valid:

[openjdk]

@asgibbons
The label hotspot-compiler is not a valid label.
These labels are valid:

[mlbridge]

Webrevs

• 00: Full (eeb6d341)

[sviswa7]

Looks good to me.

[sviswa7]

@theRealAph Could you please help reviewing this backport of openjdk/jdk#18849.

[asgibbons]

Can I please get a review on this? Thanks in advance.

[asgibbons]

@chhagedorn Could you please review this so I can get it off my plate? thanks.

[chhagedorn]

Looks good to me.

[asgibbons]

/integrate

[openjdk]

@asgibbons
Your change (at version eeb6d34) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit c025eb6.
Since your change was applied there have been 33 commits pushed to the master branch:

• 0090161: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"
• 7ae015f: 8330063: Upgrade jQuery to 3.7.1
• 83a5a4d: 8331331: :tier1 target explanation in doc/testing.md is incorrect
• dc3abee: 8309241: ClassForNameLeak fails intermittently as the class loader hasn't been unloaded
• b555bbb: 8294691: dynamicArchive/RelativePath.java is running other test case
• 379a14b: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
• 313a7e0: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
• 4e702a4: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
• a4a0a82: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null'
• 3bdbf49: 8298809: Clean up vm/compiler/InterfaceCalls JMH
• ... and 23 more: https://git.openjdk.org/jdk17u-dev/compare/879e8031949d6cd6ce82027296dd2d4325faa2bb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @asgibbons Pushed as commit c025eb6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[asgibbons]

Thanks, @jerboaa for the sponsorship of this change.