Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316973: GC: Make TestDisableDefaultGC use createTestJvm #2791

Closed
wants to merge 2 commits into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Aug 9, 2024

I backport this for parity with 17.0.13-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316973 needs maintainer approval

Issue

  • JDK-8316973: GC: Make TestDisableDefaultGC use createTestJvm (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2791/head:pull/2791
$ git checkout pull/2791

Update a local copy of the PR:
$ git checkout pull/2791
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2791/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2791

View PR using the GUI difftool:
$ git pr show -t 2791

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2791.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316973: GC: Make TestDisableDefaultGC use createTestJvm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 971b01a: 8315965: Open source various AWT applet tests
  • 0b789c1: 8332113: Update nsk.share.Log to be always verbose
  • 2e9152d: 8336928: GHA: Bundle artifacts removal broken
  • 4aa7950: 8337283: configure.log is truncated when build dir is on different filesystem

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5f4be8cea980b3c2e8e5fb2067dc64b62fa0245c 8316973: GC: Make TestDisableDefaultGC use createTestJvm Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 9, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2024

Webrevs

@openjdk openjdk bot added the approval label Aug 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 14, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

Going to push as commit 0330069.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7f78f21: 8316285: Opensource JButton manual tests
  • c09ca4e: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • 971b01a: 8315965: Open source various AWT applet tests
  • 0b789c1: 8332113: Update nsk.share.Log to be always verbose
  • 2e9152d: 8336928: GHA: Bundle artifacts removal broken
  • 4aa7950: 8337283: configure.log is truncated when build dir is on different filesystem

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 14, 2024
@openjdk openjdk bot closed this Aug 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@luchenlin Pushed as commit 0330069.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants