Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312049: runtime/logging/ClassLoadUnloadTest can be improved #2806

Closed
wants to merge 1 commit into from

Conversation

cost0much
Copy link
Contributor

@cost0much cost0much commented Aug 14, 2024

Backporting JDK-8312049 that improves ClassLoadUnloadTest; already backported to JDK21. Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later version, thus these cases are excluded. Additionally, some args in exec() were not added until a later version, thus they have been excluded.

Passes tier1 tests on Linux x86 and the test itself.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312049 needs maintainer approval

Issue

  • JDK-8312049: runtime/logging/ClassLoadUnloadTest can be improved (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2806/head:pull/2806
$ git checkout pull/2806

Update a local copy of the PR:
$ git checkout pull/2806
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2806/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2806

View PR using the GUI difftool:
$ git pr show -t 2806

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2806.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 14, 2024

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@cost0much This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312049: runtime/logging/ClassLoadUnloadTest can be improved

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 8dbd677: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • c103409: 8308891: TestCDSVMCrash.java needs @requires vm.cds
  • d12077d: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
  • 6cbedd9: 8273216: JCMD does not work across container boundaries with Podman
  • d5d26be: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
  • 2e3ca31: 8303891: Speed up Zip64SizeTest using a small ZIP64 file
  • 27c92b6: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
  • 61e0a11: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
  • 698f0e3: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 25537e9: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/ebcad8c176e5d3019a7784bfde258a91605c80fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4676b40f17dd18941f5883cb9b989ad639992a50 8312049: runtime/logging/ClassLoadUnloadTest can be improved Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 14, 2024
@cost0much cost0much marked this pull request as ready for review August 14, 2024 22:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 14, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 14, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 15, 2024

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@cost0much
Copy link
Contributor Author

/approval request Improves the test added by JDK-8312049 in JDK22. Does not apply cleanly, but the manual resolutions are trivial and have been investigated. Affected test passes. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Aug 16, 2024

@cost0much
8312049: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 16, 2024
@cost0much
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 23, 2024
@openjdk
Copy link

openjdk bot commented Aug 23, 2024

@cost0much
Your change (at version ccdfa9a) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2024

Going to push as commit be4f913.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 8dbd677: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • c103409: 8308891: TestCDSVMCrash.java needs @requires vm.cds
  • d12077d: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
  • 6cbedd9: 8273216: JCMD does not work across container boundaries with Podman
  • d5d26be: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
  • 2e3ca31: 8303891: Speed up Zip64SizeTest using a small ZIP64 file
  • 27c92b6: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
  • 61e0a11: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
  • 698f0e3: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 25537e9: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/ebcad8c176e5d3019a7784bfde258a91605c80fa...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2024
@openjdk openjdk bot closed this Aug 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2024
@openjdk
Copy link

openjdk bot commented Aug 23, 2024

@phohensee @cost0much Pushed as commit be4f913.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants