7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color

[tkiriyama]

Hi all,
This pull request is the backport of JDK-7093691.
It is clean, but the added test DisabledComboBoxFontTestAuto.java fails with some LAFs. This problem is resolved in JDK-8310072.
I created the pull request #3009 which backports JDK-8310072.

Testing:
javax/swing/JComboBox and tests using DefaultListCellRenderer class on Windows and Linux

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-7093691 needs maintainer approval

Issue

• JDK-7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3008/head:pull/3008
$ git checkout pull/3008

Update a local copy of the PR:
$ git checkout pull/3008
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3008/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3008

View PR using the GUI difftool:
$ git pr show -t 3008

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3008.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkiriyama This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7093691: Nimbus LAF: disabled JComboBox using renderer has bad font color

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 70a227f: 8333824: Unused ClassValue in VarHandles
• 9cf4adb: 8319651: Several network tests ignore vm flags when start java process
• 808c5cd: 8320673: PageFormat/CustomPaper.java has no Pass/Fail buttons; multiple instructions
• 6b4544c: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
• 3195d3d: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
• 5daf066: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated
• e3e7909: 8296709: WARNING: JNI call made without checking exceptions
• afbe310: 8326948: Force English locale for timeout formatting
• 4fea31e: 8328242: Add a log area to the PassFailJFrame
• 3146710: 8323562: SaslInputStream.read() may return wrong value
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/a6b9bfefb9a71c0adfa40ed8d31b5bcfa139ef14...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @tkiriyama This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ea934461)
• 00: Full (163e4855)

[tkiriyama]

/approval request I would like to have the change in jdk17u-dev as well, because the issue is present there too. The backport is clean, but added test DisabledComboBoxFontTestAuto.java fails with some LAFs. I will backport JDK-8310072 to resolve the test failure (#3009) . I verified that other javax/swing/JComboBox and tests using DefaultListCellRendere pass after changed.

[openjdk]

@tkiriyama
7093691: The approval request has been created successfully.

[tkiriyama]

/integrate

[openjdk]

@tkiriyama
Your change (at version ea93446) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit a72e14a.
Since your change was applied there have been 11 commits pushed to the master branch:

• 70a227f: 8333824: Unused ClassValue in VarHandles
• 9cf4adb: 8319651: Several network tests ignore vm flags when start java process
• 808c5cd: 8320673: PageFormat/CustomPaper.java has no Pass/Fail buttons; multiple instructions
• 6b4544c: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
• 3195d3d: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
• 5daf066: 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated
• e3e7909: 8296709: WARNING: JNI call made without checking exceptions
• afbe310: 8326948: Force English locale for timeout formatting
• 4fea31e: 8328242: Add a log area to the PassFailJFrame
• 3146710: 8323562: SaslInputStream.read() may return wrong value
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/a6b9bfefb9a71c0adfa40ed8d31b5bcfa139ef14...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @tkiriyama Pushed as commit a72e14a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.