Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP #3047

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 18, 2024

I would like to fix this issue in the sun crypto provider.

Clean backport except for Copyright, probably recognized clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8302225 needs maintainer approval

Issue

  • JDK-8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3047/head:pull/3047
$ git checkout pull/3047

Update a local copy of the PR:
$ git checkout pull/3047
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3047/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3047

View PR using the GUI difftool:
$ git pr show -t 3047

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3047.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4ce493f09ea3a34322462e82fd73b8375be1cba5 8302225: SunJCE Provider doesn't validate key sizes when using 'constrained' transforms for AES/KW and AES/KWP Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Nov 18, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 18, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Nov 20, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

Going to push as commit 878daef.
Since your change was applied there have been 8 commits pushed to the master branch:

  • ba64383: 8321470: ThreadLocal.nextHashCode can be static final
  • d0949c8: 8332935: Crash: assert(*lastPtr != 0) failed: Mismatched JNINativeInterface tables, check for new entries
  • 82a609d: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners
  • 6d7a6e1: 8207908: JMXStatusTest.java fails assertion intermittently
  • 8989bab: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker
  • b1fae1c: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test
  • 4b74741: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11
  • e486000: 8258734: jdk/jfr/event/oldobject/TestClassLoaderLeak.java failed with "RuntimeException: Could not find class leak"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2024
@openjdk openjdk bot closed this Nov 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@GoeLin Pushed as commit 878daef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8302225 branch November 20, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant