Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser #3198

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 9, 2025

I backport this for parity with 17.0.15-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8226933 needs maintainer approval

Issue

  • JDK-8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3198/head:pull/3198
$ git checkout pull/3198

Update a local copy of the PR:
$ git checkout pull/3198
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3198

View PR using the GUI difftool:
$ git pr show -t 3198

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3198.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 53d7539: 8336942: Improve test coverage for class loading elements with annotations of different retentions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5c4f1ef746b0c373a131726d74d27f0e0cc6e40d 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 10, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jan 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 13, 2025

Going to push as commit 59f98c1.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 7c825dd: 8314225: SIGSEGV in JavaThread::is_lock_owned
  • 06c8242: 8198237: [macos] Test java/awt/Frame/ExceptionOnSetExtendedStateTest/ExceptionOnSetExtendedStateTest.java fails
  • b0286b3: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails
  • 6a1576d: 8317636: Improve heap walking API tests to verify correctness of field indexes
  • 0228f7c: 8208565: [TEST_BUG] javax\swing\PopupFactory\6276087\NonOpaquePopupMenuTest.java throws NPE
  • c93489b: 8314610: hotspot can't compile with the latest of gtest because of
  • 36481dd: 8328368: Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main
  • 4dab8ba: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range
  • fe3e985: 8292704: sun/security/tools/jarsigner/compatibility/Compatibility.java use wrong key size for EC
  • ce49efd: 8292588: [macos] Multiscreen/MultiScreenLocationTest/MultiScreenLocationTest.java: Robot.mouseMove test failed on Screen #0
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/96100ad2f4c71d924468c1feed37f323eebf91dc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2025
@openjdk openjdk bot closed this Jan 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@GoeLin Pushed as commit 59f98c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant