8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class

[vieiro]

Backport of JDK-8339728 from 21u that solves some accessibility issues on Windows, for parity with 17.0.15/166-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk.

The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period".

The new accessibility test passes on Windows 10 (tested with JAWS v. 2025.2412.102 - February 2025 ).

Clean but for an update in copyright header in AccessBridge.java.

---

Progress

• JDK-8339728 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3291/head:pull/3291
$ git checkout pull/3291

Update a local copy of the PR:
$ git checkout pull/3291
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3291

View PR using the GUI difftool:
$ git pr show -t 3291

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3291.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vieiro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (0d71e970)

[vieiro]

/approval request Please approve this backport to JDK-17 that fixes an accessibility problem in Windows, where JMenuItem shortcuts were not properly read out. Low risk. Verified in Windows 10 with JAWS.

[openjdk]

@vieiro
8339728: The approval request has been created successfully.

[vieiro]

/integrate

[openjdk]

@vieiro
Your change (at version 0d71e97) is now ready to be sponsored by a Committer.

[vieiro]

D'oh! This was already backported by @GoeLin in #3271. Closing this one then.

[GoeLin]

Hi @vieiro, yes, I prepared a PR, but I never got to properly testing it. So please proceed with your PR.

[vieiro]

@GoeLin I'll reopen this one then.

[GoeLin]

/sponsor

[GoeLin]

Thanks for backporting this!

[openjdk]

Going to push as commit 01d107a.
Since your change was applied there have been 7 commits pushed to the master branch:

• 2846c9e: 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI
• 715d37e: 8346324: javax/swing/JScrollBar/4865918/bug4865918.java fails in CI
• 9f48d42: 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode
• f7a071e: 8337222: gc/TestDisableExplicitGC.java fails due to unexpected CodeCache GC
• d8ae039: 8314975: JavadocTester should set source path if not specified
• 45a35e8: 8301989: new javax.swing.text.DefaultCaret().setBlinkRate(N) results in NPE
• 15730c0: 8274893: Update java.desktop classes to use try-with-resources

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @vieiro Pushed as commit 01d107a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.