8300590: [JVMCI] BytecodeFrame.equals is broken

[TobiHartmann]

Backport of JDK-8300590. Applies cleanly. Approval is pending.

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300590: [JVMCI] BytecodeFrame.equals is broken

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk20u.git pull/33/head:pull/33
$ git checkout pull/33

Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.org/jdk20u.git pull/33/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33

View PR using the GUI difftool:
$ git pr show -t 33

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk20u/pull/33.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300590: [JVMCI] BytecodeFrame.equals is broken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (efbb904f)

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 17dfaaf.
Since your change was applied there have been 12 commits pushed to the master branch:

• cbc2f89: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
• 0343ba4: 8299959: C2: CmpU::Value must filter overflow computation against local sub computation
• aae19b3: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
• ac96054: 8302595: use-after-free related to GraphKit::clone_map
• fcd422d: 8302594: use-after-free in Node::destruct
• aa6d177: 8297730: C2: Arraycopy intrinsic throws incorrect exception
• bae3733: 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline
• c0a87a2: 8300823: UB: Compile::_phase_optimize_finished is initialized too late
• b4429d0: 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors
• 572b05a: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE
• ... and 2 more: https://git.openjdk.org/jdk20u/compare/0d71795814ed255c4a6e2b51cee01a264a407ad6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit 17dfaaf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.