8309595: Allow javadoc to process unnamed classes

[JimLaskey]

Unnamed classes are rejected by javadoc because they are synthetic.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309595: Allow javadoc to process unnamed classes (Bug - P3)

Reviewers

• Pavel Rappo (@pavelrappo - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/1/head:pull/1
$ git checkout pull/1

Update a local copy of the PR:
$ git checkout pull/1
$ git pull https://git.openjdk.org/jdk21.git pull/1/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1

View PR using the GUI difftool:
$ git pr show -t 1

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/1.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@JimLaskey The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (440fbd8b)

[jonathan-gibbons]

As a matter of style, tests are typically in a class whose name begins Test in a directory whose name begins test.

[kevinrushforth]

Since this is a clean backport of a fix that went into JDK mainline, do you want it changed only in the Backport?

[JimLaskey]

Would it be satisfactory to address this in mainline and also backport that change?

[kevinrushforth]

That seems best

[JimLaskey]

/integrate

[openjdk]

@JimLaskey This pull request has not yet been marked as ready for integration.

[pavelrappo]

Is it really 2017 or an unfortunate copy-paste from some other test?

[openjdk]

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309595: Allow javadoc to process unnamed classes

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• ede16cd: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
• 08965e6: 8310259: Pin msys2/setup-msys2 github action to a specific commit
• e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
• 14c5091: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
• 36e3fe9: 8309928: JFR: View issues
• 4d81b89: 8309960: ParallelGC young collections very slow in DelayInducer
• ace5623: 8308643: Incorrect value of 'used' jvmstat counter
• 3698a02: 8309756: Occasional crashes with pipewire screen capture on Wayland
• a1c1d97: 8309632: JDK 21 RDP1 L10n resource files update
• aced114: 8310128: Switch with unnamed patterns erroneously non-exhaustive
• ... and 17 more: https://git.openjdk.org/jdk21/compare/bb377b26730f3d9da7c76e0d171517e811cef3ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JimLaskey]

/integrate

[openjdk]

Going to push as commit bfffd8b.
Since your change was applied there have been 27 commits pushed to the master branch:

• ede16cd: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
• 08965e6: 8310259: Pin msys2/setup-msys2 github action to a specific commit
• e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
• 14c5091: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
• 36e3fe9: 8309928: JFR: View issues
• 4d81b89: 8309960: ParallelGC young collections very slow in DelayInducer
• ace5623: 8308643: Incorrect value of 'used' jvmstat counter
• 3698a02: 8309756: Occasional crashes with pipewire screen capture on Wayland
• a1c1d97: 8309632: JDK 21 RDP1 L10n resource files update
• aced114: 8310128: Switch with unnamed patterns erroneously non-exhaustive
• ... and 17 more: https://git.openjdk.org/jdk21/compare/bb377b26730f3d9da7c76e0d171517e811cef3ce...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JimLaskey Pushed as commit bfffd8b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.