Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8306785: fix deficient spliterators for Sequenced Collections #118

Conversation

stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Jul 13, 2023

Hi all,

This pull request contains a backport of commit 743e8b8e from the openjdk/jdk repository.

The commit being backported was authored by Stuart Marks on 12 Jul 2023 and was reviewed by Paul Sandoz.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306785: fix deficient spliterators for Sequenced Collections (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/118/head:pull/118
$ git checkout pull/118

Update a local copy of the PR:
$ git checkout pull/118
$ git pull https://git.openjdk.org/jdk21.git pull/118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 118

View PR using the GUI difftool:
$ git pr show -t 118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/118.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2023

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 743e8b8e0a9fe032a0dd652a4fef1f761af66595 8306785: fix deficient spliterators for Sequenced Collections Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306785: fix deficient spliterators for Sequenced Collections

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 99d87e9: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990
  • d174dde: 8311092: Please disable runtime/jni/nativeStack/TestNativeStack.java on armhf
  • f792475: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
  • 5f1d762: 8310656: RISC-V: __builtin___clear_cache can fail silently.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 13, 2023
@stuart-marks
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 13, 2023

Going to push as commit b4f19f5.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 65ed787: 8294401: Update jfr man page to include recently added features
  • 2475bba: 8311536: JFR TestNativeMemoryUsageEvents fails in huge pages configuration
  • 99d87e9: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990
  • d174dde: 8311092: Please disable runtime/jni/nativeStack/TestNativeStack.java on armhf
  • f792475: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
  • 5f1d762: 8310656: RISC-V: __builtin___clear_cache can fail silently.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 13, 2023
@openjdk openjdk bot closed this Jul 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 13, 2023
@openjdk
Copy link

openjdk bot commented Jul 13, 2023

@stuart-marks Pushed as commit b4f19f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants