8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990

[shipilev]

Clean backport. Fixes the regression introduced in JDK 21.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990 (Bug - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/120/head:pull/120
$ git checkout pull/120

Update a local copy of the PR:
$ git checkout pull/120
$ git pull https://git.openjdk.org/jdk21.git pull/120/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 120

View PR using the GUI difftool:
$ git pr show -t 120

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/120.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f601392d)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• d174dde: 8311092: Please disable runtime/jni/nativeStack/TestNativeStack.java on armhf
• f792475: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Test failures in GHA are unrelated.

/integrate

[openjdk]

Going to push as commit 99d87e9.
Since your change was applied there have been 2 commits pushed to the master branch:

• d174dde: 8311092: Please disable runtime/jni/nativeStack/TestNativeStack.java on armhf
• f792475: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 99d87e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.