Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8312572: JDK 21 RDP2 L10n resource files update #160

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Aug 2, 2023

Please review this PR (L10N translation update), which is a backport of commit 9b55e9a7 from the openjdk/jdk repository.

This change is required to keep the localized translations up to date with the English source resource files.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312572: JDK 21 RDP2 L10n resource files update (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.org/jdk21.git pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/160.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9b55e9a706de9893b1a71c7a6a4e23c4b8842f18 8312572: JDK 21 RDP2 L10n resource files update Aug 2, 2023
@openjdk
Copy link

openjdk bot commented Aug 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Aug 2, 2023
@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • client
  • compiler
  • core-libs
  • javadoc
  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org kulla kulla-dev@openjdk.org labels Aug 2, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312572: JDK 21 RDP2 L10n resource files update

Reviewed-by: naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 20ca046: 8313023: Return value corrupted when using CCS + isTrivial (mainline)
  • c3519d0: 8313256: Exclude failing multicast tests on AIX
  • 5a74a8d: 8313404: Fix section label in test/jdk/ProblemList.txt

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 2, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 3, 2023

Going to push as commit fd789db.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 46dd733: 8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout
  • f532042: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • 610812d: 8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [i4] but found [I4]
  • f87a70d: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
  • 20ca046: 8313023: Return value corrupted when using CCS + isTrivial (mainline)
  • c3519d0: 8313256: Exclude failing multicast tests on AIX
  • 5a74a8d: 8313404: Fix section label in test/jdk/ProblemList.txt

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 3, 2023
@openjdk openjdk bot closed this Aug 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 3, 2023
@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@justin-curtis-lu Pushed as commit fd789db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean client client-libs-dev@openjdk.org compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org kulla kulla-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

3 participants