Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8304885: Reuse stale data to improve DNS resolver resiliency #53

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 21, 2023

Hi all,

This pull request contains a backport of commit bdd81b31 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 9 Jun 2023 and was reviewed by Michael McMahon and Daniel Fuchs.

CSR is approved for JDK 21: https://bugs.openjdk.org/browse/JDK-8306653
"jdk21-enhancement-yes" label is added to the JBS.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8306653 to be approved

Issues

  • JDK-8304885: Reuse stale data to improve DNS resolver resiliency (Enhancement - P3)
  • JDK-8306653: Reuse stale data to improve DNS resolver resiliency (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/53/head:pull/53
$ git checkout pull/53

Update a local copy of the PR:
$ git checkout pull/53
$ git pull https://git.openjdk.org/jdk21.git pull/53/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 53

View PR using the GUI difftool:
$ git pr show -t 53

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/53.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bdd81b31825a9eb6a0f0883fca56a011ac2aebf8 8304885: Reuse stale data to improve DNS resolver resiliency Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@mrserb The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org net net-dev@openjdk.org labels Jun 21, 2023
@mrserb mrserb marked this pull request as ready for review June 21, 2023 22:41
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 22, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304885: Reuse stale data to improve DNS resolver resiliency

Reviewed-by: djelinski, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • e86d765: 8309853: StructuredTaskScope.join description improvements
  • 2f1af3c: 8309296: jdk/jfr/event/runtime/TestAgentEvent.java fails due to "missing" dynamic JavaAgent
  • 6317249: 8310187: Improve Generational ZGC jtreg testing
  • 55aa4cb: 8309498: [JVMCI] race in CallSiteTargetValue recording
  • 5357bcd: 8308855: ARM32: TestBooleanVector crashes after 8300257
  • 7621d98: 8309266: C2: assert(final_con == (jlong)final_int) failed: final value should be integer
  • 89ac41b: 8310126: C1: Missing receiver null check in Reference::get intrinsic
  • 789b2fc: 8302865: Illegal bytecode for break from if with instanceof pattern matching condition
  • ceadaec: 8310133: Effectivelly final condition not enforced in guards for binding variables from the same case
  • f8a38ee: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
  • ... and 3 more: https://git.openjdk.org/jdk21/compare/1fc60429a1565ca5357de08c53df53af5d24278f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2023
@mrserb
Copy link
Member Author

mrserb commented Jun 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2023

Going to push as commit 8b12726.
Since your change was applied there have been 13 commits pushed to the master branch:

  • e86d765: 8309853: StructuredTaskScope.join description improvements
  • 2f1af3c: 8309296: jdk/jfr/event/runtime/TestAgentEvent.java fails due to "missing" dynamic JavaAgent
  • 6317249: 8310187: Improve Generational ZGC jtreg testing
  • 55aa4cb: 8309498: [JVMCI] race in CallSiteTargetValue recording
  • 5357bcd: 8308855: ARM32: TestBooleanVector crashes after 8300257
  • 7621d98: 8309266: C2: assert(final_con == (jlong)final_int) failed: final value should be integer
  • 89ac41b: 8310126: C1: Missing receiver null check in Reference::get intrinsic
  • 789b2fc: 8302865: Illegal bytecode for break from if with instanceof pattern matching condition
  • ceadaec: 8310133: Effectivelly final condition not enforced in guards for binding variables from the same case
  • f8a38ee: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
  • ... and 3 more: https://git.openjdk.org/jdk21/compare/1fc60429a1565ca5357de08c53df53af5d24278f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2023
@openjdk openjdk bot closed this Jun 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2023
@openjdk
Copy link

openjdk bot commented Jun 23, 2023

@mrserb Pushed as commit 8b12726.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated net net-dev@openjdk.org security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

3 participants