8180450: secondary_super_cache does not scale well

[theRealAph]

See 8180450 for a full description of how this works.
This is a pretty clean backport, but a few files had to be fiddled manually because things had been added nearby.

This PR also includes a fix for [8337958](https://bugs.openjdk.org/browse/JDK-8337958), which was a minor bug in the original commit.

For a justification of why this PR should be backported to JDK 21u, see
Franz's email.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8180450 needs maintainer approval
• Commit message must refer to an issue
• JDK-8337958 needs maintainer approval

Issues

• JDK-8180450: secondary_super_cache does not scale well (Bug - P3 - Approved)
• JDK-8337958: Out-of-bounds array access in secondary_super_cache (Bug - P3 - Approved)

Reviewers

• Andrew Dinn (@adinn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1090/head:pull/1090
$ git checkout pull/1090

Update a local copy of the PR:
$ git checkout pull/1090
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1090/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1090

View PR using the GUI difftool:
$ git pr show -t 1090

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1090.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@theRealAph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8180450: secondary_super_cache does not scale well
8337958: Out-of-bounds array access in secondary_super_cache

Reviewed-by: adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 206 new commits pushed to the master branch:

• ef23a01: 8279016: JFR Leak Profiler is broken with Shenandoah
• c046d85: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp
• 91457e6: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor
• ae47d99: 8346082: Output JVMTI agent information in hserr files
• b942b5e: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats
• 4159e88: 8350650: Bump update version for OpenJDK: jdk-21.0.8
• 5806906: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered
• 951453e: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS
• 2f9840c: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine
• 68ad843: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir
• ... and 196 more: https://git.openjdk.org/jdk21u-dev/compare/990859cc32776e2d794de539190c9ccced1dfcd9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@theRealAph this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8180450-jdk21u-backport
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (cfce5b29)
• 00: Full (983b05e3)

[bridgekeeper]

@theRealAph This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[theRealAph]

/issue JDK-8337958

[openjdk]

@theRealAph
Adding additional issue to issue list: 8337958: Out-of-bounds array access in secondary_super_cache.

[bridgekeeper]

@theRealAph This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[theRealAph]

Bumping this. Please reconsider this patch for 21u: the problem is affecting many users.

[theRealAph]

For avoidance of doubt:

A later bug, https://bugs.openjdk.org/browse/JDK-8344355, does not apply to this PR. The bug 8344355 fixed was caused by 8331341: secondary_super_cache does not scale well: C1 and interpreter. 8331341 is not included here, and I have no intention of ever backporting it.

[adinn]

Backport looks ok to me modulo a couple of questions.

n.b. I agree this is sorely needed for jdk21u and earlier releases

[adinn]

Good to go

[openjdk]

⚠️ @theRealAph This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8180450: The approval request has been approved.
8337958: The approval request has been approved.

[mlbridge]

Mailing list message from Andrew Haley on jdk-updates-dev:

Can I get maintainer approval for this, please?

On 12/11/24 17:38, Andrew Haley wrote:

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

[mlbridge]

Mailing list message from Andrew Haley on jdk-updates-dev:

On 2/14/25 14:23, Andrew Dinn wrote:

For a justification of why this PR should be backported to JDK 21u, see
[Franz's email](https://mail.openjdk.org/pipermail/jdk-updates-dev/2024-October/038649.html).

Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:

Add check

Good to go

Maintainer approval needed for https://bugs.openjdk.org/browse/JDK-8180450
and https://bugs.openjdk.org/browse/JDK-8337958

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

[jerboaa]

@theRealAph This is ready to integrate. Please do so.

[theRealAph]

/integrate

[openjdk]

Going to push as commit ef282b7.
Since your change was applied there have been 209 commits pushed to the master branch:

• e48995f: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11
• 9d9bcd2: 8314840: 3 gc/epsilon tests ignore external vm options
• 601e6f9: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails
• ef23a01: 8279016: JFR Leak Profiler is broken with Shenandoah
• c046d85: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp
• 91457e6: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor
• ae47d99: 8346082: Output JVMTI agent information in hserr files
• b942b5e: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats
• 4159e88: 8350650: Bump update version for OpenJDK: jdk-21.0.8
• 5806906: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered
• ... and 199 more: https://git.openjdk.org/jdk21u-dev/compare/990859cc32776e2d794de539190c9ccced1dfcd9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@theRealAph Pushed as commit ef282b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.