Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336911: ZGC: Division by zero in heuristics after JDK-8332717 #1149

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 13, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336911 needs maintainer approval

Issue

  • JDK-8336911: ZGC: Division by zero in heuristics after JDK-8332717 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1149/head:pull/1149
$ git checkout pull/1149

Update a local copy of the PR:
$ git checkout pull/1149
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1149

View PR using the GUI difftool:
$ git pr show -t 1149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1149.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336911: ZGC: Division by zero in heuristics after JDK-8332717

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 5b1a952: 8336257: Additional tests in jmxremote/startstop to match on PID not app name
  • fa07b3d: 8319673: Few security tests ignore VM flags
  • bcc85d9: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux
  • 6affc09: 8340801: Disable ubsan checks in some awt/2d coding
  • 1af737e: 8339892: Several security shell tests don't set TESTJAVAOPTS
  • d0abff2: 8207908: JMXStatusTest.java fails assertion intermittently
  • c5d75ef: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags
  • d81d301: 8342181: Update tests to use stronger Key and Salt size

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1cc32237aee03a38bfb0f6679f7328a682ad6ea9 8336911: ZGC: Division by zero in heuristics after JDK-8332717 Nov 13, 2024
@openjdk
Copy link

openjdk bot commented Nov 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 13, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Nov 13, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2024

Webrevs

@MBaesken
Copy link
Member Author

macOS aarch GHA infra broken 'xcode-select: error: invalid developer directory"

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 18, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

Going to push as commit f36b3b4.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 4f6c506: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
  • 38f654e: 8343724: [PPC64] Disallow OptoScheduling
  • 1bfb57d: 8342607: Enhance register printing on x86_64 platforms
  • fe41d0a: 8343506: [s390x] multiple test failures with ubsan
  • e1eb341: 8342183: Update tests to use stronger algorithms and keys
  • 0fd3173: 8342188: Update tests to use stronger key parameters and certificates
  • 5b1a952: 8336257: Additional tests in jmxremote/startstop to match on PID not app name
  • fa07b3d: 8319673: Few security tests ignore VM flags
  • bcc85d9: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux
  • 6affc09: 8340801: Disable ubsan checks in some awt/2d coding
  • ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/22d5e0d1f8849410abe40165b58f45f5e4293884...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2024
@openjdk openjdk bot closed this Nov 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@MBaesken Pushed as commit f36b3b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant