Skip to content

8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 11, 2025

Hi all,

This pull request contains a backport of commit 155697fc from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 7 Mar 2025 and was reviewed by Thomas Stuefe.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349623 needs maintainer approval

Issue

  • JDK-8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1463/head:pull/1463
$ git checkout pull/1463

Update a local copy of the PR:
$ git checkout pull/1463
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1463

View PR using the GUI difftool:
$ git pr show -t 1463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1463.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f2ffbbd70ccaaa97cb7d05c168995dd2599a3d1d 8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails Mar 11, 2025
@openjdk
Copy link

openjdk bot commented Mar 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

GHA report 2 failures:

  1. Job hs/tier1 compiler part 3 report wget timed out failure at Get the BootJDK stage. It's environmental issue or infrastucture issue, it's unrelated to this PR.
  2. Job jdk/tier1 part 3 report test java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails BigInteger.MIN_VALUE.toString(16)=[327329765]='8'. This backport PR do not affect the JVM logic in theory, I think the test failure is unrelated to this PR.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug, which the gtest should be skip when address sanitizer is enable. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Apr 8, 2025

@sendaoYan
8349623: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant