8337981: ShenandoahHeap::is_in should check for alive regions

[satyenme]

Backporting JDK-8337981: ShenandoahHeap::is_in should check for alive regions. Fixes Shenandoah's implementation of the CollectedHeap::is_in function to not just check that oop is within the heap bounds, but to check that it is within the committed section of the heap. Ran GHA Sanity Checks, and local Tier 1, and Tier 2 tests. Patch is clean.

---

Progress

• JDK-8337981 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337981: ShenandoahHeap::is_in should check for alive regions (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1496/head:pull/1496
$ git checkout pull/1496

Update a local copy of the PR:
$ git checkout pull/1496
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1496/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1496

View PR using the GUI difftool:
$ git pr show -t 1496

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1496.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337981: ShenandoahHeap::is_in should check for alive regions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the master branch:

• 2cbb283: 8351665: Remove unused UseNUMA in os_aix.cpp
• c662d7d: 8339538: Wrong timeout computations in DnsClient
• 983307e: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive
• 32cad69: 8348598: Update Libpng to 1.6.47
• eb86458: 8348597: Update HarfBuzz to 10.4.0
• aba69de: 8342376: More reliable OOM handling in ExceptionDuringDumpAtObjectsInitPhase test
• bc4a317: 8340605: Open source several AWT PopupMenu tests
• 4e06d17: 8340143: Open source several Java2D rendering loop tests.
• 550d853: 8340367: Opensource few AWT image tests
• d3c83e5: 8339895: Open source several AWT focus tests - series 3
• ... and 108 more: https://git.openjdk.org/jdk21u-dev/compare/e48995f4997e08e50a0ed1781e1972dd5c303297...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (971383c2)

[satyenme]

/approval request for backport. Fixes Shenandoah's implementation of the CollectedHeap::is_in function to not just check that oop is within the heap bounds, but to check that it is within the committed section of the heap.

Reasoning: This change corrects Shenandoah implementation bug, enhancing the GC performance.

Risk: Low. Tip change was merged in August of 2024 without any issues. From an implementation standpoint, this change makes the is_in function slightly more conservative.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally

[openjdk]

@satyenme
8337981: The approval request has been created successfully.

[satyenme]

/approval request for backport. Fixes Shenandoah's implementation of the CollectedHeap::is_in function to not just check that oop is within the heap bounds, but to check that it is within the committed section of the heap.

Reasoning: This change corrects Shenandoah implementation bug, enhancing the GC performance.

Risk: Low. Tip change was merged in August of 2024 without any issues. From an implementation standpoint, this change makes the is_in function slightly more conservative.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally

[openjdk]

@satyenme
8337981: The approval request has been updated successfully.

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version 971383c) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 73f9206.
Since your change was applied there have been 122 commits pushed to the master branch:

• ca8d6af: 8333890: Fatal error in auto-vectorizer with float16 kernel.
• e4bdf76: 8331088: Incorrect TraceLoopPredicate output
• c7fccfe: 8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly
• 1d5d3d8: 8330158: C2: Loop strip mining uses ABS with min int
• 2cbb283: 8351665: Remove unused UseNUMA in os_aix.cpp
• c662d7d: 8339538: Wrong timeout computations in DnsClient
• 983307e: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive
• 32cad69: 8348598: Update Libpng to 1.6.47
• eb86458: 8348597: Update HarfBuzz to 10.4.0
• aba69de: 8342376: More reliable OOM handling in ExceptionDuringDumpAtObjectsInitPhase test
• ... and 112 more: https://git.openjdk.org/jdk21u-dev/compare/e48995f4997e08e50a0ed1781e1972dd5c303297...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @satyenme Pushed as commit 73f9206.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.