New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8325150: (tz) Update Timezone Data to 2024a #248
Conversation
👋 Welcome back dlutker! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/request approval clean backport of tz2024a, relevant tests passing. |
@lutkerd Unknown command |
/approval request clean backport of tz2024a, relevant tests passing. |
@lutkerd This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit b30f9aa.
Your commit was automatically rebased without conflicts. |
@gnu-andrew @lutkerd Pushed as commit b30f9aa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting tz2024a, local build and relevant tests passing on linux x64.
make run-test TEST="jdk/java/util/TimeZone jdk/java/time/test jdk/sun/util/resources jdk/sun/text/resources jdk/sun/util/calendar"
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/248/head:pull/248
$ git checkout pull/248
Update a local copy of the PR:
$ git checkout pull/248
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/248/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 248
View PR using the GUI difftool:
$ git pr show -t 248
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/248.diff
Webrev
Link to Webrev Comment