Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325150: (tz) Update Timezone Data to 2024a #248

Closed
wants to merge 1 commit into from

Conversation

lutkerd
Copy link

@lutkerd lutkerd commented Feb 8, 2024

Backporting tz2024a, local build and relevant tests passing on linux x64.

make run-test TEST="jdk/java/util/TimeZone jdk/java/time/test jdk/sun/util/resources jdk/sun/text/resources jdk/sun/util/calendar"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325150 needs maintainer approval

Issue

  • JDK-8325150: (tz) Update Timezone Data to 2024a (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/248/head:pull/248
$ git checkout pull/248

Update a local copy of the PR:
$ git checkout pull/248
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/248/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 248

View PR using the GUI difftool:
$ git pr show -t 248

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/248.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2024

👋 Welcome back dlutker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 917838e0a564b1f2cbfb6cc214ccbfd1a237019f 8325150: (tz) Update Timezone Data to 2024a Feb 8, 2024
@openjdk
Copy link

openjdk bot commented Feb 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

⚠️ @lutkerd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2024
@lutkerd
Copy link
Author

lutkerd commented Feb 8, 2024

/request approval clean backport of tz2024a, relevant tests passing.

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@lutkerd Unknown command request - for a list of valid commands use /help.

@lutkerd
Copy link
Author

lutkerd commented Feb 8, 2024

/approval request clean backport of tz2024a, relevant tests passing.

@openjdk
Copy link

openjdk bot commented Feb 8, 2024

@lutkerd
8325150: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 8, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325150: (tz) Update Timezone Data to 2024a

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0604ce7: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 9, 2024
@lutkerd
Copy link
Author

lutkerd commented Feb 9, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@lutkerd
Your change (at version edf5576) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 9, 2024

Going to push as commit b30f9aa.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 0604ce7: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 9, 2024
@openjdk openjdk bot closed this Feb 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 9, 2024
@openjdk
Copy link

openjdk bot commented Feb 9, 2024

@gnu-andrew @lutkerd Pushed as commit b30f9aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants