-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled #280
Conversation
👋 Welcome back lmao! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport of fix of pretouch for parallel gc. The original issue is reproduced with linux/aarch64 and fix is verified. The risk is quite low since it only fixed the granularity of pretouch size and won't have any other affection. |
@mmyxym This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
Could committers please help sponsor, thanks! |
/sponsor |
Going to push as commit ef13a82.
Your commit was automatically rebased without conflicts. |
@DamonFool @mmyxym Pushed as commit ef13a82. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of fix of pretouch for parallel gc. The original issue is reproduced with linux/aarch64 and fix is verified.
Additional testing:
hotspot_gc
with-XX:+UseParallelGC -XX:+AlwaysPreTouch
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/280/head:pull/280
$ git checkout pull/280
Update a local copy of the PR:
$ git checkout pull/280
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/280/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 280
View PR using the GUI difftool:
$ git pr show -t 280
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/280.diff
Webrev
Link to Webrev Comment