Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306040: HttpResponseInputStream.available() returns 1 on empty stream #309

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 1, 2024

I backport this for parity with 21.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8306040 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8306040: HttpResponseInputStream.available() returns 1 on empty stream (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/309/head:pull/309
$ git checkout pull/309

Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 309

View PR using the GUI difftool:
$ git pr show -t 309

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/309.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport acaab6fd74f507bb6b18167505d88e505bdf24bd 8306040: HttpResponseInputStream.available() returns 1 on empty stream Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2024

Webrevs

@openjdk openjdk bot added the approval label Mar 4, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 4, 2024

GHA failure: Well known Risk-V build issue. Unrelated.

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306040: HttpResponseInputStream.available() returns 1 on empty stream

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 2d62854: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java
  • fdbed07: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • dbcce04: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 500d85a: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • ee6445c: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 94634c0: 8313394: Array Elements in OldObjectSample event has the incorrect description

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 5, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

Going to push as commit 4244cb0.
Since your change was applied there have been 7 commits pushed to the master branch:

  • d6ad625: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • 2d62854: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java
  • fdbed07: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • dbcce04: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 500d85a: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • ee6445c: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 94634c0: 8313394: Array Elements in OldObjectSample event has the incorrect description

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 5, 2024
@openjdk openjdk bot closed this Mar 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 5, 2024
@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@GoeLin Pushed as commit 4244cb0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant