8317300: javac erroneously allows "final" in front of a record pattern

[shipilev]

Transplanted to jdk21u-dev from openjdk/jdk21u#369

Clean backport to fix the new language feature support; innocuous, but fixing it earlier is beneficial for avoiding accidents (i.e. build failures when migrating to newer JDKs).

Additional testing:

• MacOS AArch64 server fastdebug, new test fails without the fix, passes with it
• MacOS AArch64 server fastdebug, tools/javac pass

---

Progress

• Change requires CSR request JDK-8320789 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317300 needs maintainer approval

Issues

• JDK-8317300: javac erroneously allows "final" in front of a record pattern (Bug - P4 - Approved)
• JDK-8320789: javac erroneously allows "final" in front of a record pattern (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/5/head:pull/5
$ git checkout pull/5

Update a local copy of the PR:
$ git checkout pull/5
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/5/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5

View PR using the GUI difftool:
$ git pr show -t 5

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/5.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (90c39c30)

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317300: javac erroneously allows "final" in front of a record pattern

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• fb34573: 8321894: Bump update version for OpenJDK: 21.0.3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

CSR is approved. Push approval granted.

/integrate

[openjdk]

Going to push as commit ee7748a.
Since your change was applied there have been 23 commits pushed to the master branch:

• d50fd26: 8314990: Generational ZGC: Strong OopStorage stats reported as weak roots
• c3b0c03: 8319668: Fixup of jar filename typo in BadFactoryTest.sh
• 2062596: 8320208: Update Public Suffix List to b5bf572
• 16554ae: 8316392: compiler/interpreter/TestVerifyStackAfterDeopt.java failed with SIGBUS in PcDescContainer::find_pc_desc_internal
• 6f3cd91: 8316028: Update FreeType to 2.13.2
• c0b78b7: 8316410: GC: Make TestCompressedClassFlags use createTestJvm
• be19bda: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
• 9e8cee6: 8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm
• 16875f2: 8315988: Parallel: Make TestAggressiveHeap use createTestJvm
• a75b88d: 8314838: 3 compiler tests ignore vm flags
• ... and 13 more: https://git.openjdk.org/jdk21u-dev/compare/ba79073da5baede8d381cd495fb82379b6775f09...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit ee7748a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.