8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665

[shipilev]

This fixes the regression introduced by JDK-8329665, which added ResourceMark in frame::oops_interpreted_do. This is not really correct, as closures we call with that method can do resource allocations. The patch avoids this problem by cleanly allocating on C heap.

The mainline patch wants has_valid_mask infrastructure added as part of JDK-8315954. That patch has implications for Graal, and have unresolved bug tail. Therefore, I just picked up relevant infra hunks here.

Additional testing:

• Linux x86_64 server fastedebug, all
• Linux AArch64 server fastedebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8335409 needs maintainer approval

Issue

• JDK-8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 (Bug - P2 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/942/head:pull/942
$ git checkout pull/942

Update a local copy of the PR:
$ git checkout pull/942
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/942/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 942

View PR using the GUI difftool:
$ git pr show -t 942

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/942.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665

Reviewed-by: phh, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 4f28612: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• b8038ea: 8335743: jhsdb jstack cannot print some information on the waiting thread
• e79f9b4: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
• 24f453c: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage
• dc8365c: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
• fa8ef0f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (31683b28)

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request This fixes the regression introduced by JDK-8329665, which added ResourceMark in frame::oops_interpreted_do. Patch does not apply cleanly to jdk21u-dev, needs more adjustments, see PR. All tests pass. Risk is low-medium: touches a frequent path, was in mainline for 6 weeks, is being released in JDK 23 as well.

[openjdk]

@shipilev
8335409: The approval request has been created successfully.

[tstuefe]

This looks good to me.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit db914b7.
Since your change was applied there have been 12 commits pushed to the master branch:

• 345b417: 8338286: GHA: Demote x86_32 to hotspot build only
• ec5976d: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range
• 15664b1: 8322881: java/nio/file/Files/CopyMoveVariations.java fails with AccessDeniedException due to permissions of files in /tmp
• dccf4de: 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment
• f2c5ecf: 8336284: Test TestClhsdbJstackLock.java/TestJhsdbJstackLock.java fails with -Xcomp after JDK-8335743
• fe47075: 8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0
• 4f28612: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• b8038ea: 8335743: jhsdb jstack cannot print some information on the waiting thread
• e79f9b4: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
• 24f453c: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage
• ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/d5b8ea8dacdfb7cbd9e9d5fb98a2571db2e1bf6b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit db914b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.