Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers #101

Closed

Conversation

coffeys
Copy link
Contributor

@coffeys coffeys commented Aug 25, 2023

Reduce the excessive number of InvalidParameterSpecException objects created in TLS environments where non-JDK provider may be in use


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/101/head:pull/101
$ git checkout pull/101

Update a local copy of the PR:
$ git checkout pull/101
$ git pull https://git.openjdk.org/jdk21u.git pull/101/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 101

View PR using the GUI difftool:
$ git pr show -t 101

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/101.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e554fdee254ce51d605fe127b73644620e87e23b 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • c849fa5: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
  • 4729fad: 8313312: Add missing classpath exception copyright header
  • 7a2aa86: 8314020: Print instruction blocks in byte units
  • 17a7fc3: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f6bd169: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
  • 6588678: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • 5c84a01: 8314517: some tests fail in case ipv6 is disabled on the machine
  • 5ad0c0c: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 82d7bc5: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix)
  • c17b5d7: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
  • ... and 4 more: https://git.openjdk.org/jdk21u/compare/89aea0dace4afd2b1bbc5d636322969afcf0072c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2023

Webrevs

@coffeys
Copy link
Contributor Author

coffeys commented Aug 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit b96aa3c.
Since your change was applied there have been 15 commits pushed to the master branch:

  • a34b844: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • c849fa5: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154
  • 4729fad: 8313312: Add missing classpath exception copyright header
  • 7a2aa86: 8314020: Print instruction blocks in byte units
  • 17a7fc3: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • f6bd169: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
  • 6588678: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • 5c84a01: 8314517: some tests fail in case ipv6 is disabled on the machine
  • 5ad0c0c: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 82d7bc5: 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix)
  • ... and 5 more: https://git.openjdk.org/jdk21u/compare/89aea0dace4afd2b1bbc5d636322969afcf0072c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@coffeys Pushed as commit b96aa3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant