-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8242152: SA does not include StackMapTables when dumping .class files #129
Conversation
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@wkia This change is no longer ready for integration - check the PR body for details. |
/integrate |
@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@wkia This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@wkia This pull request is now open |
@wkia This PR needs to move to 21u-dev for 21.0.3 integration. jdk21u is currently closed for pushes. Once created, please re-apply for approval. |
This PR should be closed, btw. |
@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi @wkia, please close this PR. You need to backport this to jdk21u-dev if you want to get it into 21. That is the development repo. |
Clean backport.
Tests in "serviceability/sa" run locallly on Linux (because of GHA skips these tests on Linux with SkippedException) - passed.
NOTE that this is a PR chain, "serviceability/sa/ClhsdbDumpclass" will fail until the next PR #130 is integrated.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/129/head:pull/129
$ git checkout pull/129
Update a local copy of the PR:
$ git checkout pull/129
$ git pull https://git.openjdk.org/jdk21u.git pull/129/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 129
View PR using the GUI difftool:
$ git pr show -t 129
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/129.diff
Webrev
Link to Webrev Comment