-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316387: Exclude more failing multicast tests on AIX after JDK-8315651 #173
8316387: Exclude more failing multicast tests on AIX after JDK-8315651 #173
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8316399 |
@RealCLanger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/approval request Add some AIX specific test exclusions. |
@RealCLanger There are multiple issues associated with this pull request, you need to request approval for each one individually. |
/approval JDK-8316387 request Add some AIX specific test exclusions. |
/approval JDK-8316399 request Add some AIX specific test exclusions. |
@RealCLanger The approval request has been created successfully. |
@RealCLanger The approval request has been created successfully. |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit c86bad5.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit c86bad5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
/backport jdk17u-dev |
@suchismith1993 Could not automatically backport
Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk17u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.
Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk17u-dev with the title Below you can find a suggestion for the pull request body:
|
Backport some AIX specific test exclusions.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/173/head:pull/173
$ git checkout pull/173
Update a local copy of the PR:
$ git checkout pull/173
$ git pull https://git.openjdk.org/jdk21u.git pull/173/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 173
View PR using the GUI difftool:
$ git pr show -t 173
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/173.diff
Webrev
Link to Webrev Comment