Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314242: Update applications/scimark/Scimark.java to accept VM flags #302

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 30, 2023

I backport this for parity with 17.0.10-oracle.


Progress

  • JDK-8314242 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314242: Update applications/scimark/Scimark.java to accept VM flags (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/302/head:pull/302
$ git checkout pull/302

Update a local copy of the PR:
$ git checkout pull/302
$ git pull https://git.openjdk.org/jdk21u.git pull/302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 302

View PR using the GUI difftool:
$ git pr show -t 302

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/302.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6bf4a33593bfe0df9b5ba81de5321a04f4dbe0ea 8314242: Update applications/scimark/Scimark.java to accept VM flags Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 30, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Oct 30, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 30, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314242: Update applications/scimark/Scimark.java to accept VM flags

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 504f4a0: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
  • e2b89c7: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
  • 892938d: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 3552d5a: 8316659: assert(LockingMode != LM_LIGHTWEIGHT || flag == CCR0) failed: bad condition register
  • b743ba8: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • e371a3d: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • 07a1490: 8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing
  • bb7c86f: 8318415: Adjust describing comment of os_getChildren after 8315026
  • bb8db71: 8318089: Class space not marked as such with NMT when CDS is off
  • ... and 16 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 3, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Nov 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

Going to push as commit 4a6c0d8.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 504f4a0: 8286757: adlc tries to build with /pathmap but without /experimental:deterministic
  • e2b89c7: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
  • 892938d: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • 844c32a: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests
  • 3552d5a: 8316659: assert(LockingMode != LM_LIGHTWEIGHT || flag == CCR0) failed: bad condition register
  • b743ba8: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • e371a3d: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • 07a1490: 8316411: compiler/compilercontrol/TestConflictInlineCommands.java fails intermittent with force inline by CompileCommand missing
  • bb7c86f: 8318415: Adjust describing comment of os_getChildren after 8315026
  • bb8db71: 8318089: Class space not marked as such with NMT when CDS is off
  • ... and 16 more: https://git.openjdk.org/jdk21u/compare/f4ed66ee82c2d01eb5cef213af8f3d8bf0242d6c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2023
@openjdk openjdk bot closed this Nov 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@GoeLin Pushed as commit 4a6c0d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant