Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316719: C2 compilation still fails with "bad AD file" #342

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 9, 2023

Clean backport to amend previous C2 regression fix. Applies cleanly.

Additional testing:

  • New regression test fails without the fix, passes with it
  • Linux x86_64 server fastdebug, tier1 tier2 tier3 tier4

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316719 needs maintainer approval

Issue

  • JDK-8316719: C2 compilation still fails with "bad AD file" (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/342/head:pull/342
$ git checkout pull/342

Update a local copy of the PR:
$ git checkout pull/342
$ git pull https://git.openjdk.org/jdk21u.git pull/342/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 342

View PR using the GUI difftool:
$ git pr show -t 342

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/342.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1e687b4529ae695d991623dc13796faecd6be7da 8316719: C2 compilation still fails with "bad AD file" Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 9, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2023

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to amend previous C2 regression fix. Applies cleanly. Testing passes.

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@shipilev
8316719: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316719: C2 compilation still fails with "bad AD file"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 015dab9: 8316030: Update Libpng to 1.6.40
  • dfca3b9: 8319184: RISC-V: improve MD5 intrinsic
  • 8998f6f: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • 1ba77d9: 8312174: missing JVMTI events from vthreads parked during JVMTI attach
  • 81eaed2: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 545b1fe: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • 67f5d7b: 8318525: Atomic gtest should run as TEST_VM to access VM capabilities
  • cd4ce01: 8315920: C2: "control input must dominate current control" assert failure
  • fb7d858: 8316436: ContinuationWrapper uses unhandled nullptr oop
  • bac4829: 8312433: HttpClient request fails due to connection being considered idle and closed
  • ... and 12 more: https://git.openjdk.org/jdk21u/compare/37888d29125e2ac818600543eb065ea5bf01897e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 16, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

Going to push as commit a25ea4c.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 015dab9: 8316030: Update Libpng to 1.6.40
  • dfca3b9: 8319184: RISC-V: improve MD5 intrinsic
  • 8998f6f: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • 1ba77d9: 8312174: missing JVMTI events from vthreads parked during JVMTI attach
  • 81eaed2: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 545b1fe: 8316935: [s390x] Use consistent naming for lightweight locking in MacroAssembler
  • 67f5d7b: 8318525: Atomic gtest should run as TEST_VM to access VM capabilities
  • cd4ce01: 8315920: C2: "control input must dominate current control" assert failure
  • fb7d858: 8316436: ContinuationWrapper uses unhandled nullptr oop
  • bac4829: 8312433: HttpClient request fails due to connection being considered idle and closed
  • ... and 12 more: https://git.openjdk.org/jdk21u/compare/37888d29125e2ac818600543eb065ea5bf01897e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2023
@openjdk openjdk bot closed this Nov 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@shipilev Pushed as commit a25ea4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8316719-c2-bad-ad-again branch November 28, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant