Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318759: Add four DigiCert root certificates #363

Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Nov 14, 2023

Clean backport to JDK 21u


Progress

  • Change must not contain extraneous whitespace
  • JDK-8318759 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8318759: Add four DigiCert root certificates (Enhancement - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/363/head:pull/363
$ git checkout pull/363

Update a local copy of the PR:
$ git checkout pull/363
$ git pull https://git.openjdk.org/jdk21u.git pull/363/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 363

View PR using the GUI difftool:
$ git pr show -t 363

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/363.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0ea58048f9b4cdaaa0470b2bcc03913fb3939453 8318759: Add four DigiCert root certificates Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

⚠️ @rhalade This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2023

Webrevs

@rhalade
Copy link
Member Author

rhalade commented Nov 14, 2023

/approval 8318759 request The fix is to add new root CA certificate. The patch applies cleanly and has good test coverage.

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@rhalade
8318759: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318759: Add four DigiCert root certificates

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 015dab9: 8316030: Update Libpng to 1.6.40
  • dfca3b9: 8319184: RISC-V: improve MD5 intrinsic
  • 8998f6f: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • 1ba77d9: 8312174: missing JVMTI events from vthreads parked during JVMTI attach

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 16, 2023
@rhalade
Copy link
Member Author

rhalade commented Nov 17, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

Going to push as commit cb352c2.
Since your change was applied there have been 9 commits pushed to the master branch:

  • d603f8a: 8312191: ColorConvertOp.filter for the default destination is too slow
  • 245885b: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • 71eec78: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit
  • fb9bd49: 8317581: [s390x] Multiple test failure with LockingMode=2
  • a25ea4c: 8316719: C2 compilation still fails with "bad AD file"
  • 015dab9: 8316030: Update Libpng to 1.6.40
  • dfca3b9: 8319184: RISC-V: improve MD5 intrinsic
  • 8998f6f: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • 1ba77d9: 8312174: missing JVMTI events from vthreads parked during JVMTI attach

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 17, 2023
@openjdk openjdk bot closed this Nov 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@rhalade Pushed as commit cb352c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant