Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301310: The SendRawSysexMessage test may cause a JVM crash #366

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 14, 2023

Hi all,

This pull request contains a backport of commit d725b73d from the openjdk/jdk repository.

The commit being backported was authored by Alec Su on 14 Nov 2023 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • JDK-8301310 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301310: The SendRawSysexMessage test may cause a JVM crash (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/366/head:pull/366
$ git checkout pull/366

Update a local copy of the PR:
$ git checkout pull/366
$ git pull https://git.openjdk.org/jdk21u.git pull/366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 366

View PR using the GUI difftool:
$ git pr show -t 366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/366.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d725b73df01ae4478dfaabc47c48cd7231d91afa 8301310: The SendRawSysexMessage test may cause a JVM crash Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review November 15, 2023 05:06
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2023

Webrevs

@shipilev
Copy link
Member

shipilev commented Nov 22, 2023

Are you planning to ask for maintainer approval, or are we waiting for something here, @mrserb?

@openjdk openjdk bot added the approval label Nov 28, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 14, 2023

Sorry, but this PR needs to move to jdk21u-dev now. Once done, please ask for approval again.

@openjdk openjdk bot removed the approval label Dec 14, 2023
@openjdk openjdk bot added the approval label Jan 2, 2024
@GoeLin
Copy link
Member

GoeLin commented Jan 2, 2024

Hi @mrserb, can you please close this PR? Thanks.

@mrserb mrserb closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
4 participants