Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313678: SymbolTable can leak Symbols during cleanup #73

Conversation

olivergillespie
Copy link
Contributor

@olivergillespie olivergillespie commented Aug 21, 2023

Clean backport for https://bugs.openjdk.org/browse/JDK-8313678.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313678: SymbolTable can leak Symbols during cleanup (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/73/head:pull/73
$ git checkout pull/73

Update a local copy of the PR:
$ git checkout pull/73
$ git pull https://git.openjdk.org/jdk21u.git pull/73/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 73

View PR using the GUI difftool:
$ git pr show -t 73

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/73.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4b2703ad39f8160264eb30c797824cc93a6b56e2 8313678: SymbolTable can leak Symbols during cleanup Aug 21, 2023
@openjdk
Copy link

openjdk bot commented Aug 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 21, 2023

@olivergillespie This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313678: SymbolTable can leak Symbols during cleanup

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 77b5fa2: 8284772: GHA: Use GCC Major Version Dependencies Only
  • 8bf3ba3: 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch.
  • 2408df2: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
  • 1f5ba7a: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 34e9be5: 8312620: WSL Linux build crashes after JDK-8310233
  • 4cca633: 8312182: THPs cause huge RSS due to thread start timing issue
  • 89234bc: 8303815: Improve Metaspace test speed
  • 3f889a8: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 4909911: 8314960: Add Certigna Root CA - 2
  • f5eef20: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • ... and 26 more: https://git.openjdk.org/jdk21u/compare/be077e0667bfd046862aa7994a61fe36356c9afe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2023

Webrevs

@olivergillespie
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@olivergillespie
Your change (at version 3dfca00) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 29, 2023

Going to push as commit c189275.
Since your change was applied there have been 37 commits pushed to the master branch:

  • af9d11e: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores
  • 77b5fa2: 8284772: GHA: Use GCC Major Version Dependencies Only
  • 8bf3ba3: 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch.
  • 2408df2: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
  • 1f5ba7a: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 34e9be5: 8312620: WSL Linux build crashes after JDK-8310233
  • 4cca633: 8312182: THPs cause huge RSS due to thread start timing issue
  • 89234bc: 8303815: Improve Metaspace test speed
  • 3f889a8: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 4909911: 8314960: Add Certigna Root CA - 2
  • ... and 27 more: https://git.openjdk.org/jdk21u/compare/be077e0667bfd046862aa7994a61fe36356c9afe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 29, 2023
@openjdk openjdk bot closed this Aug 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@phohensee @olivergillespie Pushed as commit c189275.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@olivergillespie olivergillespie deleted the olivergillespie-backport-4b2703ad branch August 29, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants