Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280991: [XWayland] No displayChanged event after setDisplayMode call #111

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Mar 5, 2025

Hi all,

This pull request contains a backport of commit 29de20db from the openjdk/jdk repository.

It was not clean due to the conflict in the copyright year, (in 25 it was updated separately by openjdk/jdk@64fad1c)

The commit being backported was authored by Alexander Zvegintsev on 4 Mar 2025 and was reviewed by Harshitha Onkar and Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8280991 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8280991: [XWayland] No displayChanged event after setDisplayMode call (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/111/head:pull/111
$ git checkout pull/111

Update a local copy of the PR:
$ git checkout pull/111
$ git pull https://git.openjdk.org/jdk24u.git pull/111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 111

View PR using the GUI difftool:
$ git pr show -t 111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/111.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2025

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2025

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280991: [XWayland] No displayChanged event after setDisplayMode call

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 0ceff4b: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases
  • 320ce2f: 8350201: Out of bounds access on Linux aarch64 in os::print_register_info
  • 23389d0: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs
  • 1603de1: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
  • 33960cf: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS
  • 6109c0b: 8351033: RISC-V: TestFloat16ScalarOperations asserts with offset (4210) is too large to be patched in one beq/bge/bgeu/blt/bltu/bne instruction!

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 29de20dbc22e0b68698a1b9cb1241ae5861a6b9a 8280991: [XWayland] No displayChanged event after setDisplayMode call Mar 5, 2025
@openjdk
Copy link

openjdk bot commented Mar 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 5, 2025

⚠️ @azvegint This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 5, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2025

Webrevs

@azvegint
Copy link
Member Author

azvegint commented Mar 5, 2025

/approval request

Clean backport to support correct emulated screen resolution switching in XWayland.

@openjdk
Copy link

openjdk bot commented Mar 5, 2025

@azvegint
8280991: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 5, 2025
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit 31a383a.
Since your change was applied there have been 7 commits pushed to the master branch:

  • f2ffbbd: 8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails
  • 0ceff4b: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases
  • 320ce2f: 8350201: Out of bounds access on Linux aarch64 in os::print_register_info
  • 23389d0: 8350483: AArch64: turn on signum intrinsics by default on Ampere CPUs
  • 1603de1: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
  • 33960cf: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS
  • 6109c0b: 8351033: RISC-V: TestFloat16ScalarOperations asserts with offset (4210) is too large to be patched in one beq/bge/bgeu/blt/bltu/bne instruction!

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@azvegint Pushed as commit 31a383a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant