Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version #133

Closed
wants to merge 1 commit into from

Conversation

rgangadhar
Copy link
Member

@rgangadhar rgangadhar commented Mar 13, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349492 needs maintainer approval

Issue

  • JDK-8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/133/head:pull/133
$ git checkout pull/133

Update a local copy of the PR:
$ git checkout pull/133
$ git pull https://git.openjdk.org/jdk24u.git pull/133/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 133

View PR using the GUI difftool:
$ git pr show -t 133

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/133.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2025

👋 Welcome back rgangadhar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

@rgangadhar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

  • 186c4f0: 8303770: Remove Baltimore root certificate expiring in May 2025
  • 5e7fe59: 8349214: Improve size optimization flags for MSVC builds
  • 8a4f476: 8343191: Cgroup v1 subsystem fails to set subsystem path
  • f004355: 8286204: [Accessibility,macOS,VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS
  • 366c0f9: 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4
  • f1798aa: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed
  • 170adf3: 8342775: [Graal] java/util/concurrent/locks/Lock/OOMEInAQS.java fails OOME thrown from the UncaughtExceptionHandler
  • 881b653: 8348596: Update FreeType to 2.13.3
  • 945f91a: 8348110: Update LCMS to 2.17
  • a2c3b81: 8346264: "Total compile time" counter should include time spent in failing/bailout compiles
  • ... and 60 more: https://git.openjdk.org/jdk24u/compare/2280d5bc817b4248e9000c12cc8b3c953dbae737...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 8d8bd0c4b3bfdc7670bba03b01b0a00dac9f9825 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version Mar 13, 2025
@openjdk
Copy link

openjdk bot commented Mar 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

⚠️ @rgangadhar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2025

Webrevs

@rgangadhar
Copy link
Member Author

/approval JDK-8349492 request Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

@rgangadhar
JDK-8349492: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 13, 2025
@rgangadhar
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 18, 2025
@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@rgangadhar
Your change (at version 0a0975e) is now ready to be sponsored by a Committer.

@mpdonova
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@mpdonova Only Committers are allowed to sponsor changes.

@rhalade
Copy link
Member

rhalade commented Mar 19, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

Going to push as commit f20051f.
Since your change was applied there have been 73 commits pushed to the master branch:

  • 60cf6a1: 8351639: Improve debuggability of test/langtools/jdk/jshell/JdiHangingListenExecutionControlTest.java test
  • 080f997: 8348597: Update HarfBuzz to 10.4.0
  • 7a47dcb: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
  • 186c4f0: 8303770: Remove Baltimore root certificate expiring in May 2025
  • 5e7fe59: 8349214: Improve size optimization flags for MSVC builds
  • 8a4f476: 8343191: Cgroup v1 subsystem fails to set subsystem path
  • f004355: 8286204: [Accessibility,macOS,VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS
  • 366c0f9: 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4
  • f1798aa: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed
  • 170adf3: 8342775: [Graal] java/util/concurrent/locks/Lock/OOMEInAQS.java fails OOME thrown from the UncaughtExceptionHandler
  • ... and 63 more: https://git.openjdk.org/jdk24u/compare/2280d5bc817b4248e9000c12cc8b3c953dbae737...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 19, 2025
@openjdk openjdk bot closed this Mar 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 19, 2025
@openjdk
Copy link

openjdk bot commented Mar 19, 2025

@rhalade @rgangadhar Pushed as commit f20051f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants