Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336042: Caller/callee param size mismatch in deoptimization causes crash #156

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Mar 24, 2025

Hi all,

This pull request contains a backport of commit 20ea218c from the openjdk/jdk repository.

The commit being backported was authored by Dean Long on 4 Mar 2025 and was reviewed by Patricio Chilano Mateo, Richard Reingruber, Vladimir Ivanov and Tom Rodriguez.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336042 needs maintainer approval

Issue

  • JDK-8336042: Caller/callee param size mismatch in deoptimization causes crash (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/156/head:pull/156
$ git checkout pull/156

Update a local copy of the PR:
$ git checkout pull/156
$ git pull https://git.openjdk.org/jdk24u.git pull/156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 156

View PR using the GUI difftool:
$ git pr show -t 156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/156.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2025

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336042: Caller/callee param size mismatch in deoptimization causes crash

Reviewed-by: dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9aa311f: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
  • e0f1ebc: 8346285: Update jarsigner compatibility test for change in default digest algorithm

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 20ea218ce52f79704445acfe2d4a3dc9d04e86d2 8336042: Caller/callee param size mismatch in deoptimization causes crash Mar 24, 2025
@openjdk
Copy link

openjdk bot commented Mar 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Mar 24, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 24, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 26, 2025
@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 27, 2025

Going to push as commit 4128d17.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 4ed3f6e: 8352512: TestVectorZeroCount: counter not reset between iterations
  • 9aa311f: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
  • e0f1ebc: 8346285: Update jarsigner compatibility test for change in default digest algorithm

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2025
@openjdk openjdk bot closed this Mar 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2025
@openjdk
Copy link

openjdk bot commented Mar 27, 2025

@TobiHartmann Pushed as commit 4128d17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants