New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert #276
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks. Flagged for approval. |
I see |
Going to push as commit 1ee22a7.
Your commit was automatically rebased without conflicts. |
@gnu-andrew Pushed as commit 1ee22a7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Changes apply cleanly bar the
ProblemList.txt
removal as JDK-8243543 was never backported. This is much the same as the backports of JDK-8248899 (openjdk/jdk8u#35) and JDK-8243543 (openjdk/jdk8u#34)All
security/infra
tests pass with the patch, with the exception ofActalisCA.java
(problem listed) and the two tests fixed by the aforementioned PRs (will be fixed when 8u372-b05 is promoted & merged into jdk8u-dev)Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/276/head:pull/276
$ git checkout pull/276
Update a local copy of the PR:
$ git checkout pull/276
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/276/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 276
View PR using the GUI difftool:
$ git pr show -t 276
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/276.diff
Webrev
Link to Webrev Comment