Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296343: CPVE thrown on missing content-length in OCSP response #332

Closed
wants to merge 4 commits into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jun 7, 2023

Hi!

Here is backport of JDK-8296343: CPVE thrown on missing content-length in OCSP response. The patch from 11u applied with the following changes (except the path shuflling):

jdk/src/java.base/share/classes/sun/security/provider/certpath/OCSP.java

  • reading response content from the input stream reworked due to InputStream.readAllBytes() and IOUtils.readExactlyNBytes() are not available in 8

jdk/test/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java

  • unsupported List.of() and Set.of() replaced with equivalent code
  • added a newline at the end of the file

Verification (amd64/20.04): newly added test/jdk/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java FAILS, will be fixed by backporting of JDK-8300939
Regression (amd64/20.04): jdk_security


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #331 must be integrated first

Issue

  • JDK-8296343: CPVE thrown on missing content-length in OCSP response (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/332/head:pull/332
$ git checkout pull/332

Update a local copy of the PR:
$ git checkout pull/332
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/332/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 332

View PR using the GUI difftool:
$ git pr show -t 332

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/332.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2023

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into pr/331 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1a3cb8c5018bc016c2ad6b078e4abe13b39d151c 8296343: CPVE thrown on missing content-length in OCSP response Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 7, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@apavlyutkin
Copy link
Contributor Author

Please don't close this, bot.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2023

@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant