Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8159156: [TESTBUG] ReserveMemory test is not useful on Aix. #358

Closed
wants to merge 1 commit into from

Conversation

Larry-N
Copy link

@Larry-N Larry-N commented Aug 25, 2023

Backport of JDK-8159156 [TESTBUG] ReserveMemory test is not useful on Aix.
Applied cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8159156: [TESTBUG] ReserveMemory test is not useful on Aix. (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/358/head:pull/358
$ git checkout pull/358

Update a local copy of the PR:
$ git checkout pull/358
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/358/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 358

View PR using the GUI difftool:
$ git pr show -t 358

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/358.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

👋 Welcome back inakonechnyy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8bb3799029d34e7f5bbc3d9e5bc6da7068360bc7 8159156: [TESTBUG] ReserveMemory test is not useful on Aix. Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 25, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2023

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Sep 5, 2023

Only path changes have been done, marking as clean.

/clean

@openjdk openjdk bot added the clean label Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@jerboaa This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8159156: [TESTBUG] ReserveMemory test is not useful on Aix.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 89a08b3: 8315506: C99 compatibility issue in LinuxNativeDispatcher
  • 6632d0a: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
  • 33db95b: 8315280: Bump update version of OpenJDK: 8u402
  • bbc068f: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value
  • 6c67bf6: 8212677: X11 default visual support for IM status window on VNC
  • 79cae43: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 5, 2023
@Larry-N
Copy link
Author

Larry-N commented Sep 5, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@Larry-N
Your change (at version 8f8422e) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Contributor

yan-too commented Sep 6, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 6, 2023

Going to push as commit 1fc2e33.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 115e74d: 8239365: ProcessBuilder test modifications for AIX execution
  • 89a08b3: 8315506: C99 compatibility issue in LinuxNativeDispatcher
  • 6632d0a: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
  • 33db95b: 8315280: Bump update version of OpenJDK: 8u402
  • bbc068f: 8206179: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java fails with Committed virtual memory size illegal value
  • 6c67bf6: 8212677: X11 default visual support for IM status window on VNC
  • 79cae43: 6528710: sRGB-ColorSpace to sRGB-ColorSpace Conversion

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 6, 2023
@openjdk openjdk bot closed this Sep 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@yan-too @Larry-N Pushed as commit 1fc2e33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

4 participants