Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301310: The SendRawSysexMessage test may cause a JVM crash #395

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 28, 2023

Hi all,

This pull request contains a backport of commit d725b73d from the openjdk/jdk repository.

The commit being backported was authored by Alec Su on 14 Nov 2023 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • JDK-8301310 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301310: The SendRawSysexMessage test may cause a JVM crash (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/395/head:pull/395
$ git checkout pull/395

Update a local copy of the PR:
$ git checkout pull/395
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 395

View PR using the GUI difftool:
$ git pr show -t 395

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/395.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d725b73df01ae4478dfaabc47c48cd7231d91afa 8301310: The SendRawSysexMessage test may cause a JVM crash Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 28, 2023
@mrserb mrserb marked this pull request as ready for review November 28, 2023 04:18
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2023

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Nov 28, 2023

/clean The patch is clean, only the paths are changed

@openjdk openjdk bot added the clean label Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301310: The SendRawSysexMessage test may cause a JVM crash

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 74a3ddd: 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set
  • b610be3: 8308592: Framework for CA interoperability testing
  • b05e679: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 8cf7c96: 8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios
  • a226a47: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • 2f81fb4: 8251551: Use .md filename extension for README
  • b2655a7: 8297955: LDAP CertStore should use LdapName and not String for DNs
  • 3b9c787: 8208655: use JTreg skipped status in hotspot tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 6, 2023
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean (sans paths) against the 22u version.

@mrserb
Copy link
Member Author

mrserb commented Dec 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2023

Going to push as commit 3db93fc.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 74a3ddd: 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set
  • b610be3: 8308592: Framework for CA interoperability testing
  • b05e679: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 8cf7c96: 8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios
  • a226a47: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • 2f81fb4: 8251551: Use .md filename extension for README
  • b2655a7: 8297955: LDAP CertStore should use LdapName and not String for DNs
  • 3b9c787: 8208655: use JTreg skipped status in hotspot tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2023
@openjdk openjdk bot closed this Dec 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

@mrserb Pushed as commit 3db93fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8301310 branch December 8, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants