New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318759: Add four DigiCert root certificates #399
8318759: Add four DigiCert root certificates #399
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
linux-x86 test failure appears unrelated. |
d26d6e9
to
59a8780
Compare
dc542fe
to
a1b7364
Compare
@jerboaa this pull request can not be integrated into git checkout jdk-8318759-add-four-digicert-certs
git fetch https://git.openjdk.org/jdk8u-dev.git pr/398
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/398"
git push |
@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout jdk-8318759-add-four-digicert-certs
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
a1b7364
to
3b40fb6
Compare
@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks clean (sans paths). New tests pass.
/approve yes |
@gnu-andrew |
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 7098ac7. |
Backport for adding 4 new digicert root certificates. Patch applies clean modulo path shuffeling.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/399/head:pull/399
$ git checkout pull/399
Update a local copy of the PR:
$ git checkout pull/399
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/399/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 399
View PR using the GUI difftool:
$ git pr show -t 399
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/399.diff
Webrev
Link to Webrev Comment