Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails #423

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 21, 2024

Hi all,
This pull request contains a backport of commit 54a29a44 from the openjdk/jdk repository.
The commit being backported was authored by Phil Race on 19 Oct 2021 and was reviewed by Sergey Bylokhov, Jayathirth D V and Alexander Zuev.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8192931 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/423/head:pull/423
$ git checkout pull/423

Update a local copy of the PR:
$ git checkout pull/423
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 423

View PR using the GUI difftool:
$ git pr show -t 423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/423.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 54a29a4470a0482c6b7f9f2d695e357044e684a7 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails Jan 21, 2024
@openjdk
Copy link

openjdk bot commented Jan 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 21, 2024
@mrserb mrserb marked this pull request as ready for review January 21, 2024 00:31
@mrserb
Copy link
Member Author

mrserb commented Jan 21, 2024

/clean only the test is deleted

@openjdk openjdk bot added approval rfr Pull request is ready for review clean labels Jan 21, 2024
@openjdk
Copy link

openjdk bot commented Jan 21, 2024

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jan 21, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Jan 21, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 6, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4a69ad2: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 6, 2024
@mrserb
Copy link
Member Author

mrserb commented Feb 6, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 6, 2024

Going to push as commit 474c8c1.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 4a69ad2: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2024
@openjdk openjdk bot closed this Feb 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 6, 2024
@openjdk
Copy link

openjdk bot commented Feb 6, 2024

@mrserb Pushed as commit 474c8c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant