8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3

[gnu-andrew]

In testing sun/security/krb5/auto/ReplayCacheTestProc.java following JDK-8168518, I found both it and sun/security/krb5/auto/rcache_usemd5.sh failed on RHEL 8. This did not seem to be a regression caused by the 8u412 change as it failed on the current release, 8u402. The failure was further confirmed by @martinuy who found it was due to the newer Kerberos version on RHEL 8, and it passed on Fedora 31.

@jerboaa alerted me to JDK-8258855 and backporting this change to 8u makes the tests pass.

The code changes apply as is. The headers have to be adjusted slightly to take into account the different DNS options used in 8u. The change to test/jdk/sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java also moves to jdk/test/sun/security/krb5/auto/rcache_usemd5.sh on 8u and has to be manually applied. I looked briefly at backporting JDK-8180569 which refactors these Kerberos shell tests into Java tests, and I think it has merit, but is likely quite involved and requires other test library backports. For now, we can just backport this change as the shell script is different to the one removed by 8180569 with or without this patch applied first.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8258855 needs maintainer approval

Issue

• JDK-8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3 (Bug - P3 - Approved)

Reviewers

• Martin Balao (@martinuy - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/481/head:pull/481
$ git checkout pull/481

Update a local copy of the PR:
$ git checkout pull/481
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/481/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 481

View PR using the GUI difftool:
$ git pr show -t 481

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/481.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3

Reviewed-by: mbalao, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 68ab0f3: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
• 0e0b018: Merge
• 43cb875: 8317507: C2 compilation fails with "Exceeded _node_regs array"
• 97be547: 8322122: Enhance generation of addresses
• 2ffb900: 8322114: Improve Pack 200 handling
• ce255d6: 8319851: Improve exception logging
• 54419d4: 8318340: Improve RSA key implementations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e054dc60)

[martinuy]

Thanks for proposing this backport. Looks good to me.

[openjdk]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[gnu-andrew]

• Test failures are the Certigna certificate and a sporadic HotSpot GC test failure, gc/logging/TestGCId.java
• Build failures seem to be down to Buster inaccessibility for the cross-compile. With it going EOL at the end of June, we may need to backport JDK-8314658 to upgrade to bullseye.

None of them relate to this change.

[gnu-andrew]

/approval request Nearly clean test backport which fixes the Kerberos replay test on systems with a newer version of mit-krb5 (e.g. RHEL 8). Backport was reviewed by Martin Balao and Sergey Bylokhov.

[openjdk]

@gnu-andrew
8258855: The approval request has been created successfully.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8258855: The approval request has been approved.

[gnu-andrew]

/integrate

[openjdk]

Going to push as commit 6b53212.
Since your change was applied there have been 8 commits pushed to the master branch:

• 6a09637: 8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited
• 68ab0f3: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
• 0e0b018: Merge
• 43cb875: 8317507: C2 compilation fails with "Exceeded _node_regs array"
• 97be547: 8322122: Enhance generation of addresses
• 2ffb900: 8322114: Improve Pack 200 handling
• ce255d6: 8319851: Improve exception logging
• 54419d4: 8318340: Improve RSA key implementations

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit 6b53212.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.