8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"

[psawant19]

This is a backport PR which needs to go along JDK-8235834. As I'm backporting JDK-8235834, so need to backport this change as well JDK-8239965.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8239965 needs maintainer approval

Issue

• JDK-8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly" (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/500/head:pull/500
$ git checkout pull/500

Update a local copy of the PR:
$ git checkout pull/500
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 500

View PR using the GUI difftool:
$ git pr show -t 500

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/500.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psawant19! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@psawant19 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"

Cp943 and x-IBM943 should skip on XMLEncoder/Test4625418.java

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[mlbridge]

Webrevs

• 00: Full (e6b10065)

[psawant19]

@jerboaa Could you please review this PR.

[jerboaa]

Looks good. The test wasn't problem-listed on 8u so it's fine that hunk not being present. Otherwise the patch is clean modulo path shuffeling.

[openjdk]

⚠️ @psawant19 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[psawant19]

/approval request This back port PR needs to go along JDK-8235834 issue. PR ( #476 )

[openjdk]

@psawant19
8239965: The approval request has been created successfully.

[openjdk]

⚠️ @psawant19 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout IBM943-support-backport-24e646
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[psawant19]

/integrate

[openjdk]

@psawant19
Your change (at version e6b1006) is now ready to be sponsored by a Committer.

[psawant19]

@jerboaa, thank you for the approval.
Would you be able to sponsor my PR.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 7bcaeb5.
Since your change was applied there have been 2 commits pushed to the master branch:

• ab408de: 8235834: IBM-943 charset encoder needs updating
• b3308b1: 8328825: Google CAInterop test failures

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @psawant19 Pushed as commit 7bcaeb5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.