Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8179457: Remove demo/jvmti tests #624

Closed
wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 21, 2025

Hi all,

This is backport of JDK-8179457 from jdk11u-dev to jdk8u-dev. The demos themselves have been removed. The tests are only testing the demos and does not seem to provide any other useful product testing. This PR remove demo/jvmti tests. Test-fix only, no risk.

Below files can not backport cleanly:

  1. File jdk/test/demo/jvmti/Context.java touch by JDK-7027502 in jdk11u-dev before JDK-8179457
  2. File jdk/test/demo/jvmti/DemoRun.java touch by JDK-8076471/JDK-8071464 in jdk11u-dev before JDK-8179457
  3. File jdk/test/demo/jvmti/minst/MinstTest.java touch by JDK-8078896 in jdk11u-dev before JDK-8179457
  4. File jdk/test/ProblemList.txt has different context between jdk11u-dev and jdk8u-dev.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8179457 needs maintainer approval

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/624/head:pull/624
$ git checkout pull/624

Update a local copy of the PR:
$ git checkout pull/624
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 624

View PR using the GUI difftool:
$ git pr show -t 624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/624.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7ebbf0f8404eb17b70806f4fb7cc289470d31b2e 8179457: Remove demo/jvmti tests Feb 21, 2025
@openjdk
Copy link

openjdk bot commented Feb 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 21, 2025
@sendaoYan sendaoYan marked this pull request as draft February 21, 2025 09:03
@openjdk openjdk bot removed the rfr Pull request is ready for review label Feb 21, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

@sendaoYan
Copy link
Member Author

Sorry, the build/linux-x86_64-normal-server-release/jdk/demo/jvmti still exists in jdk8u-dev.

@sendaoYan sendaoYan closed this Feb 21, 2025
@sendaoYan sendaoYan deleted the jbs8179457 branch February 21, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants