New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263404: RsaPrivateKeySpec is always recognized as RSAPrivateCrtKeySpec in RSAKeyFactory.engineGetKeySpec #41
Conversation
👋 Welcome back phh! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
8u is frozen as of 2023-03-24. We are not currently accepting critical fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (same as openjdk/jdk8u-dev#302).
@phohensee This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Please close this one. |
Patch will go into jdk8u-dev after all. |
Critical fix, so replaces openjdk/jdk8u-dev#302, which was against jdk8u-dev.
The backport from 11u was not clean because:
The new test and the modified existing tests pass, and the jdk/test/sun/security/pkcs11 tests pass as well as they did before this change.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/41/head:pull/41
$ git checkout pull/41
Update a local copy of the PR:
$ git checkout pull/41
$ git pull https://git.openjdk.org/jdk8u.git pull/41/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 41
View PR using the GUI difftool:
$ git pr show -t 41
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/41.diff
Webrev
Link to Webrev Comment