Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README based on feedback #222

Closed
wants to merge 2 commits into from
Closed

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Feb 20, 2024

  • Change references from jdk 21 to jdk 22
  • Update JEP number and recommend LLVM version
  • Amend instructions for jdk version needed to run gradle
  • Add note that example indicating that a native library is required

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (no review required)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/222/head:pull/222
$ git checkout pull/222

Update a local copy of the PR:
$ git checkout pull/222
$ git pull https://git.openjdk.org/jextract.git pull/222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 222

View PR using the GUI difftool:
$ git pr show -t 222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/222.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- Change references from jdk 21 to jdk 22
- Amend instructions for jdk version needed to run gradle
- Add note that example indicating that a native library is required

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2024

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@JornVernee JornVernee marked this pull request as ready for review February 20, 2024 15:39
@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@JornVernee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Update README based on feedback

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 20, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2024

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 20, 2024

Going to push as commit 3a0b4cf.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 20, 2024
@openjdk openjdk bot closed this Feb 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 20, 2024
@openjdk
Copy link

openjdk bot commented Feb 20, 2024

@JornVernee Pushed as commit 3a0b4cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JornVernee JornVernee deleted the patch-2 branch February 20, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants