Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271205: [windows] Intermittent test failure in test.javafx.scene.web.MiscellaneousTest::testDOMTimer #1113

Closed
wants to merge 1 commit into from

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Apr 25, 2023

Issue: [windows] Intermittent test failure in test.javafx.scene.web.MiscellaneousTest::testDOMTimer
Analysis:
setTimeout call is not a real-time function. it is considered just a minimum delay before the callback is executed. The actual time taken depends

  1. How long it takes to process any messages ahead of the already task in the queue?
  2. Current load on the CPU.
  3. The number of tasks being executed by the JS engine.
  4. current state of OS/Browser.

However, we have to set a minimum timeout value of at least 10 ms, as recommended by Webkit/w3c. Setting value of 1o ms might prevent some un-defined behavior.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8271205: [windows] Intermittent test failure in test.javafx.scene.web.MiscellaneousTest::testDOMTimer

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1113/head:pull/1113
$ git checkout pull/1113

Update a local copy of the PR:
$ git checkout pull/1113
$ git pull https://git.openjdk.org/jfx.git pull/1113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1113

View PR using the GUI difftool:
$ git pr show -t 1113

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1113.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2023

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Apr 25, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2023

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this is addressing the actual problem.

@jaybhaskar jaybhaskar closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
2 participants