Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319996: Update to GCC 13.2.0 on Linux #1286

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 14, 2023

This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match JDK 22.

I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8319996: Update to GCC 13.2.0 on Linux (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1286/head:pull/1286
$ git checkout pull/1286

Update a local copy of the PR:
$ git checkout pull/1286
$ git pull https://git.openjdk.org/jfx.git pull/1286/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1286

View PR using the GUI difftool:
$ git pr show -t 1286

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1286.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth kevinrushforth marked this pull request as ready for review November 14, 2023 17:20
@kevinrushforth
Copy link
Member Author

Reviewers: @arapte @johanvos @tiainen

/reviewers 2

@openjdk openjdk bot added the rfr Ready for review label Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Nov 14, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319996: Update to GCC 13.2.0 on Linux

Reviewed-by: arapte, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 59c86bb: 8303478: DatePicker throws uncatchable exception on tab out from garbled text
  • c6783b1: 8319341: [Linux] Remove operation to show or hide children because it is unnecessary

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Nov 16, 2023
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

Going to push as commit 2e73304.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 59c86bb: 8303478: DatePicker throws uncatchable exception on tab out from garbled text
  • c6783b1: 8319341: [Linux] Remove operation to show or hide children because it is unnecessary

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2023
@openjdk openjdk bot closed this Nov 16, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@kevinrushforth Pushed as commit 2e73304.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8319996-gcc-13.2 branch November 16, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants